-
Notifications
You must be signed in to change notification settings - Fork 545
CXX-3002 update release notes to account for new branch protection rules #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestion to link to MANA.
Grouping the current set of branches into the following categories:
the new rulesets can be summarized as follows:
Note "Require a Pull Request" also applies the following rules:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new @mongodb/dbx-c-cxx-releases team has been created to selectively grant permissions to bypass new branch protection rules, which are now implemented as rulesets rather than "classic" branch protection rules. This allows for individual rules to be defined and applied to selective branches and tags as a union of protections rules (rather than needing to ensure a single exclusive branch protection rule applies to any given branch). The currently proposed list of rulesets (as well which are currently applied to any given branch) may be viewed here.
Note
All branches and tags are now protected by one or more of these new rulesets.
This new "releases" team is added to the bypass list for all relevant branch and tag protection rules which may conflict with our release process in advance. (Note: individual users cannot be added to the bypass list.) Team members who are assigned the responsibility of performing a release will need to be temporarily added to this team in order to inherit required permissions (i.e. branch and tag creation) for the duration of the release process. This prevents the need to frequently modify the bypass list of individual rulesets: only team membership needs to be updated. The list of members in this team should be kept as small as possible to ensure branch protection rules are regularly enforced
(with the exception of the repo administrator, aka the Lead/Staff engineer)(team membership can be maintained via MANA permissions, including having no members at all).