Skip to content

CSHARP-4455: Fix test assertation. #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2022
Merged

CSHARP-4455: Fix test assertation. #994

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31070eb
CSHARP-4455: Fix test assertation.
DmitryLukyanov Dec 16, 2022
3a46e13
Change exception type.
DmitryLukyanov Dec 16, 2022
36c51a9
Update tests/MongoDB.Driver.Tests/Specifications/client-side-encrypti…
DmitryLukyanov Dec 16, 2022
5f4c8a8
Update tests/MongoDB.Driver.Tests/Specifications/client-side-encrypti…
DmitryLukyanov Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ver.Tests/Specifications/client-side-encryption/prose-tests/ClientEncryptionProseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,7 +1737,17 @@ void AssertException(Exception ex)
// AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY must not be configured
case "aws":
{
AssertInnerEncryptionException<AmazonServiceException>(ex, "Unable to get IAM security credentials from EC2 Instance Metadata Service.");
try
{
AssertInnerEncryptionException<AmazonServiceException>(ex, "Unable to get IAM security credentials from EC2 Instance Metadata Service.");
}
catch (XunitException)
{
// in rare cases, the thrown error is "HttpRequest exception: AcceessDeniedException". That means you don't have authorization to perform the requested action.
// It more or less corresponds to the expected behavior here, but it's unclear why the same scenario triggers different exceptions.
// However, it looks harmless to slightly update the test assertation to avoid assertation failures on EG
AssertInnerEncryptionException<HttpRequestException>(ex, "Error in KMS response. HTTP status=400. Response body=\n{\"__type\":\"AccessDeniedException\"}");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% confident that thrown exception in this (and similar) patches is HttpRequestException. But if no, we will see it and will be able to fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to reproduce it before merging, but given that I saw this exception around 5 times in total during last few months, my attempts might be not enough to do it for sure, but at least we can try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found and fixed. See for details.

}
}
break;
case "azure":
Expand Down