CSHARP-4442: Hide aws sdk in release package. #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also consider the same changes for other 3rd parties we have even though it might be considered as minor BC |
DmitryLukyanov
commented
Dec 3, 2022
| @@ -31,6 +31,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.8.0" /> | |||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.4.0" /> | |||
| <PackageReference Include="AWSSDK.SecurityToken" Version="3.7.100.14" PrivateAssets="All" /> | |||
There was a problem hiding this comment.
this is needed because aws.sdk classes became invisible for all consumers including our tests
DmitryLukyanov
added a commit
that referenced
this pull request
Dec 5, 2022
This reverts commit 77d144c.
|
Apparently this change broke our tests in core TFs. We need investigating how it can be fixed as a separate effort, reverted for now |
DmitryLukyanov
added a commit
that referenced
this pull request
Dec 6, 2022
BorisDog
pushed a commit
to BorisDog/mongo-csharp-driver
that referenced
this pull request
Dec 22, 2022
BorisDog
pushed a commit
to BorisDog/mongo-csharp-driver
that referenced
this pull request
Dec 22, 2022
This reverts commit 77d144c.
BorisDog
pushed a commit
to BorisDog/mongo-csharp-driver
that referenced
this pull request
Jan 30, 2023
BorisDog
pushed a commit
to BorisDog/mongo-csharp-driver
that referenced
this pull request
Jan 30, 2023
This reverts commit 77d144c.
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
This reverts commit 77d144c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without applied fix, a consumer will see:
and therefore will be able to use aws sdk public classes.
The applied change hides this internal (for the driver) classes from consumers.
As a result, aws.sdk public classes will be unavailable for driver's consumers