Prototype using public read-only property in POCO as discriminator #1824
+199
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papafe
reviewed
Nov 25, 2025
Contributor
papafe
left a comment
papafe
left a comment
There was a problem hiding this comment.
I think the prototype looks good, and it would unlock some new possibilities for developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype of how we might be able to support using a public read-only property of a POCO as the discriminator.
The key is to configure which property (if any) of the POCO to use as the discriminator. That's what the new
[BsonDiscriminatorMember]attribute andSetDiscriminatorMembermethod are about.The rest of the changes are some relatively small changes to account for the fact that the differences between a hidden
_tfield and a public POCO member.