CSHARP-4634: Error in LINQ3 provider when custom ObjectSerializer is used #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstam
requested changes
May 10, 2023
| throw new BsonSerializationException("Can't set discriminator convention on custom object serializer."); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
You need to also change the no-argument constructor to:
public DiscriminatedInterfaceSerializer()
: this(discriminatorConvention: null)
{
}
and postpone the lookup of the DiscriminatorConvention until later.
| @@ -81,7 +81,19 @@ public DiscriminatedInterfaceSerializer(IDiscriminatorConvention discriminatorCo | |||
|
|
|||
| _interfaceType = typeof(TInterface); | |||
| _discriminatorConvention = discriminatorConvention; | |||
There was a problem hiding this comment.
_discriminatorConvention = discriminatorConvention ?? BsonSerializer.LookupDiscriminatorConvention(typeof(TInterface));
| _objectSerializer = BsonSerializer.LookupSerializer<object>(); | ||
| if (_objectSerializer is ObjectSerializer standardObjectSerializer) | ||
| { | ||
| _objectSerializer = standardObjectSerializer.WithDiscriminatorConvention(discriminatorConvention); |
There was a problem hiding this comment.
Probably need to pass _discriminatorConvention instead of discriminatorConvention here.
rstam
approved these changes
May 18, 2023
| @@ -80,8 +80,20 @@ public DiscriminatedInterfaceSerializer(IDiscriminatorConvention discriminatorCo | |||
| } | |||
|
|
|||
| _interfaceType = typeof(TInterface); | |||
| _discriminatorConvention = discriminatorConvention; | |||
| _objectSerializer = ((ObjectSerializer)BsonSerializer.LookupSerializer<object>()).WithDiscriminatorConvention(_discriminatorConvention); | |||
| _discriminatorConvention = discriminatorConvention ?? BsonSerializer.LookupDiscriminatorConvention(typeof(TInterface));; | |||
There was a problem hiding this comment.
Ups, removed. Thanks!
rstam
pushed a commit
that referenced
this pull request
May 24, 2023
dnickless
pushed a commit
to dnickless/mongo-csharp-driver
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.