CDRIVER-4502: Handle int64 connectionId values in hello responses #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Oct 17, 2022
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Thank you for the fix.
kevinAlbs
pushed a commit
that referenced
this pull request
Oct 17, 2022
kevinAlbs
pushed a commit
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDRIVER-4502
This updates the server description and command monitoring struct to store the connection ID as
int64_tto reflect the type returned by the server.mongoc_server_description_handle_hellowas updated to accept any integer for theconnectionIdfield in the response and will read the field as int64.To preserve backward compatibility,
mongoc_apm_command_started_get_server_connection_id(and the equivalent methods for other command monitoring events) still return the value asint32_t. If the connection ID returned from the server exceeds the 32-bit range,-1is returned.