Skip to content

[MONGOCRYPT-876] Remove ENABLE_WINDOWS_STATIC_RUNTIME #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vector-of-bool wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −6
Open

[MONGOCRYPT-876] Remove ENABLE_WINDOWS_STATIC_RUNTIME #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# ChangeLog

## Unreleased

### Removed

- The configure-time CMake parameter `ENABLE_WINDOWS_STATIC_RUNTIME` has been
removed. Users that need the static MSVCRT library should instead set the
[`CMAKE_MSVC_RUNTIME_LIBRARY`][msvcrt] built-in CMake parameter when
configuring libmongocrypt.

[msvcrt]: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html

## 1.17.1

Add package for Debian Trixie.
Expand Down Expand Up @@ -202,7 +213,7 @@ This release makes backwards breaking changes to Queryable Encryption (QE) behav
## Warnings
- This release has a severe bug in the context returned by `mongocrypt_ctx_rewrap_many_datakey_init` that may result in data corruption. Please upgrade to 1.5.2 before using `mongocrypt_ctx_rewrap_many_datakey_init`.
## Fixed
- Update to use new payload for FLE 2.0 find.
- Update to use new payload for FLE 2.0 find.
- Require contention factor.
## 1.5.0-rc2
### Fixed
Expand All @@ -222,7 +233,7 @@ This release makes backwards breaking changes to Queryable Encryption (QE) behav
## 1.5.0-rc0
## Fixed
- Account for shared library rename.
- Update to use new payload for FLE 2.0 find.
- Update to use new payload for FLE 2.0 find.

## 1.5.0-alpha2
## New Features
Expand Down
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ option (ENABLE_PIC
option (ENABLE_BUILD_FOR_PPA "Maintainer-only option for preparing PPA build" OFF)
option (ENABLE_ONLINE_TESTS "Enable online tests and the csfle utility. Requires libmongoc." ON)

if (ENABLE_WINDOWS_STATIC_RUNTIME)
set (CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
endif ()

if (MINGW)
# MSVCRT-based mingw-w64 GCC requires this macro to enable C99 format specifiers. This does not apply to UCRT-based
# mingw-w64 GCC, but apply the workaround anyways until bson-compat.h no longer requires this.
Expand Down