Skip to content

RUST-1384 Impl Send for Ctx #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022
Merged

RUST-1384 Impl Send for Ctx #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bdbdb
RUST-1384 Impl Send for Ctx
abr-egn Aug 4, 2022
025130d
document thread safety reasoning
abr-egn Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions mongocrypt/src/ctx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ pub struct Ctx {
inner: OwnedPtr<sys::mongocrypt_ctx_t>,
}

// Functions on `mongocrypt_ctx_t` are not threadsafe but do not rely on any thread-local state, so `Ctx` is `Send` but not `Sync.
unsafe impl Send for Ctx {}

impl HasStatus for Ctx {
unsafe fn native_status(&self, status: *mut sys::mongocrypt_status_t) {
sys::mongocrypt_ctx_status(*self.inner.borrow(), status);
Expand Down Expand Up @@ -524,6 +527,10 @@ pub struct KmsScope<'ctx> {
ctx: &'ctx Ctx,
}

// Handling multiple KMS requests is threadsafe, so `KmsScope` can be both `Send` and `Sync`.
unsafe impl<'ctx> Send for KmsScope<'ctx> {}
unsafe impl<'ctx> Sync for KmsScope<'ctx> {}

// This is `Iterator`-like but does not impl that because it's encouraged for multiple `KmsCtx` to
// be retrieved and processed in parallel, as reflected in the `&self` shared reference rather than
// `Iterator`'s exclusive `next(&mut self)`.
Expand Down