Removed @mixin Builder comment from Model.php

[promatik]

Fix for #2922.

This change fdfb5e5#diff-284e164f76aeb13f424d154f9208d91fdbb0112b0a50ad8b1dfa237176f03cf2 introduced a breaking change for phpstan, it now wrongly infers models as Illuminate\Database\Eloquent\Model, instead of it's main class.

Salut @GromNaN!
As the author of that change, is it necessary? Can we go back to what it was?

Checklist

• Add tests and ensure they pass
• Add an entry to the CHANGELOG.md file
• Update documentation for new features

[GromNaN]

Thanks for the feedback. Could you provide an example of static analysis that is broken with this change, that was not before. Thanks.

[GromNaN]

From my POV, this annotation enables autocompletion of builder's methods in PHPStorm.
If that creates an issue, the solution will be to declare all the methods with @method annotation.

[promatik]

UPDATE:

@GromNaN I think I found the issue;

use ...
use MongoDB\Laravel\Query\Builder as QueryBuilder;
use ...

Probably PHPStorm understands that Builder is actually the QueryBuilder, but PHPStand doesn't.

I changed Builder to QueryBuilder and PHPStan is not throwing me any errors 🎉

Also updated the PR.
Can you please test this on PHPStorn?

[GromNaN]

That's a different class, the exposed methods are wrong with this change.
Example, MongoDB\Laravel\Eloquent\Builder::aggregates returns AggregationBuilder | mixed while MongoDB\Laravel\Query\Builder::aggregates returns AggregationBuilder | self.

I tried to reproduce with PHPStan but didn't find the bug.
https://phpstan.org/r/10adb986-2c43-4b77-9a80-6f31d562441f

Try removing or changing the @mixin annotation to see the error.

[promatik]

Hey @GromNaN!

Yeah, sorry for the mistake, now I see it's a different class.

Anyway, I can see mixin works as expected in your demo, but I can't fix my issue 🫤
With the mixing there, my model wrongly becomes a Illuminate\Database\Eloquent\Model.

 ------ -------------------------------------------------------------------------------------- 
  Line   2024_04_26_225522_add_share_slug_to_calls_table.php
 ------ --------------------------------------------------------------------------------------
  :16    Access to an undefined property Illuminate\Database\Eloquent\Model::$share_code.
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
 ------ --------------------------------------------------------------------------------------

By the way, I'm using larastan/larastan and I think the problem comes from there, because I just tried phpstan alone, and everything works 🤷‍♂️

Let's move the issue to Larastan 👌
larastan/larastan#1940

[promatik]

Hey @GromNaN, sorry for bothering again.
Based on this comment; larastan/larastan#1940 (comment)

Might this be an issue on this implementation? I have no idea about these inner ways of work of stan.

I'm trying to upgrade to v4.3, but the 30+ phpstan errors are keeping me away form it.

[GromNaN]

Fixed by #2981

[promatik]

Great!
Thank you @GromNaN 🎉