Skip to content

Remove compatibility layers with old Laravel versions #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 11, 2023

To make the library compatible with several major versions of Laravel, abstraction method had to be added by #1116 and 3e26e05b. They are no longer necessary.

@codecov-commenter

This comment was marked as resolved.

*
* @return string
*/
public function getOwnerKey()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced as a compatibility layer in #1116

*
* @return string
*/
protected function guessBelongsToManyRelation()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced as a compatibility layer in 3e26e05b

@GromNaN GromNaN marked this pull request as ready for review September 12, 2023 21:21
@GromNaN GromNaN requested review from jmikola and alcaeus September 12, 2023 21:21
@GromNaN GromNaN merged commit 9956dc5 into mongodb:master Sep 13, 2023
@GromNaN GromNaN deleted the renamed-props branch September 13, 2023 05:59
@GromNaN GromNaN added this to the 4.0 milestone Nov 2, 2023
@GromNaN GromNaN mentioned this pull request Nov 15, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants