Skip to content

Remove legacy from readme #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Remove legacy from readme #2586

merged 2 commits into from
Aug 31, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Aug 30, 2023

Link to the jenssegers/mongodb package for old versions.
Lumen is deprecated.

@GromNaN GromNaN requested review from jmikola and alcaeus August 30, 2023 12:17
@GromNaN GromNaN added this to the 4.0.0 milestone Aug 30, 2023
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the Packagist URL, but other changes LGTM.

README.md Outdated
@@ -8,12 +8,11 @@ Laravel MongoDB

This package adds functionalities to the Eloquent model and Query builder for MongoDB, using the original Laravel API. *This library extends the original Laravel classes, so it uses exactly the same methods.*

This package was renamed to `mongodb/laravel-mongodb` because of a transfer of ownership to MongoDB, Inc.
It is compatible with Laravel 10.x. For older versions of Laravel, please refer to the [old versions](https://packagist.org/packages/jenssegers/mongodb).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this URL differ from https://packagist.org/packages/mongodb/laravel-mongodb? Both show the same tags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, nothing except the readme on the homepage will not be updated. I updated link to the old version: https://github.com/mongodb/laravel-mongodb/tree/3.9#laravel-version-compatibility

I found the old versions can be installed for using the new package name even if that's not the name in composer.json.

@GromNaN GromNaN merged commit ab02a25 into mongodb:master Aug 31, 2023
@GromNaN GromNaN deleted the readme branch August 31, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants