Skip to content

Fix: remove incompatible return type #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Fix: remove incompatible return type #2517

merged 2 commits into from
Feb 22, 2023

Conversation

saulens22
Copy link
Contributor

Fixes a bug introduced in #2506

Commit: 226a709

setAttribute in Laravel has it's return type declared as mixed, making this method incompatible: https://github.com/laravel/framework/blob/10.x/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L933-L940

This pull request removes return type. A method with no return type is mixed by default.

divine
divine previously approved these changes Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 89.91% // Head: 89.91% // No change to project coverage 👍

Coverage data is based on head (7b814df) compared to base (57010c0).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2517   +/-   ##
=========================================
  Coverage     89.91%   89.91%           
  Complexity      712      712           
=========================================
  Files            32       32           
  Lines          1726     1726           
=========================================
  Hits           1552     1552           
  Misses          174      174           
Impacted Files Coverage Δ
src/Eloquent/Model.php 91.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@divine divine merged commit 7669dc2 into mongodb:master Feb 22, 2023
@saulens22 saulens22 deleted the patch-1 branch February 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants