-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[3.9] Use correct package name when looking up version #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 88.25% // Head: 89.86% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2511 +/- ##
============================================
+ Coverage 88.25% 89.86% +1.60%
- Complexity 701 712 +11
============================================
Files 32 32
Lines 1712 1727 +15
============================================
+ Hits 1511 1552 +41
+ Misses 201 175 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@alcaeus master branch has changes with laravel 10, maybe to change destination branch from master to 3.9 ? |
@Smolevich that's a good point, but there is no 3.9 branch. If you could create one based on the latest 3.9 release and push it I'll rebase and re-target this PR. |
Let's do it |
f8464fa
to
c257c25
Compare
@Smolevich I can't push the branch myself, but once it's pushed this PR can be changed to target 3.9. I've rebased on top of |
We need to update the master branch as well. |
Fixes #2510.