Skip to content

[3.9] Fix/stringable sort #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2022
Merged

[3.9] Fix/stringable sort #2420

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6c9678
support stringable objects when sorting
apeisa Jul 16, 2022
496f8a0
style code fixes
apeisa Jul 16, 2022
50221ef
style code fixes pt. 2
apeisa Jul 16, 2022
ed86610
make the stringable object type safe
apeisa Jul 16, 2022
3a87b28
style code fixes pt. 3
apeisa Jul 16, 2022
f7895bc
Update tests/QueryTest.php
apeisa Jul 25, 2022
f670c5f
Update tests/QueryTest.php
apeisa Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make the stringable object type safe
  • Loading branch information
@apeisa
apeisa committed Jul 16, 2022
commit ed86610b85245653f8aa83f6deab7b71da92039a
4 changes: 2 additions & 2 deletions tests/QueryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,9 @@ public function testMultipleSortOrder(): void
* Mockup class to test stringable objects.
*/
class stringableObject implements Stringable {
private $string;
private String $string;

public function __construct($string)
public function __construct(String $string)
{
$this->string = $string;
}
Expand Down