Skip to content

chore: use todo instead of fixme and remove ticket reference #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

chore: use todo instead of fixme and remove ticket reference #786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d150495
chore: use todo instead of fixme and remove ticket reference
nbbeeken Mar 14, 2025
548869b
wip
nbbeeken Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .evergreen/perf_send.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ if (!Number.isInteger(order)) throw new Error(`Failed to parse integer from orde

const results = JSON.parse(await fs.readFile(resultFile, 'utf8'));

// FIXME(NODE-6838): We are using dummy dates here just to be able to successfully post our results
// TODO: this isn't ideal but we'll fix it if it becomes a real problem at some point
// These fields are required by the /raw_perf_results endpoint but are not actually used in our dashboards
for (const r of results) {
r.created_at = new Date().toISOString();
r.completed_at = new Date().toISOString();
Expand Down