Skip to content

test(NODE-6756): add tags to benchmarks #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Mar 11, 2025
Merged

test(NODE-6756): add tags to benchmarks #751

merged 29 commits into from
Mar 11, 2025

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Feb 14, 2025

Description

What is changing?

  • Update lockfile to use new bson-bench version
  • Add tags to granular benchmarks via getTypeTestTags and getMixedTestTags helper
  • Add tags to spec benchmarks
  • Add tags to custom benchmarks
  • Add script to run baseline benchmark to package.json
  • Update custom benchmark runner to support cpu baseline benchmark
  • Update readme to reflect changes in custom benchmark runner
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title test(NODE-6756): update bsonBench to add tags test(NODE-6756): add tags to benchmarks Feb 14, 2025
@W-A-James W-A-James marked this pull request as ready for review February 27, 2025 23:29
@W-A-James W-A-James requested a review from a team as a code owner February 27, 2025 23:29
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 28, 2025
@nbbeeken nbbeeken self-assigned this Feb 28, 2025
@nbbeeken
Copy link
Contributor

The granular benchmarks timed out after 15min, it says the base commit takes 5min which I find a bit surprising, did we accidentally change iterations here? and should we do it intentionally later for a larger sample size? 😅

@W-A-James W-A-James requested a review from nbbeeken March 5, 2025 17:43
@nbbeeken
Copy link
Contributor

evergreen retry

@nbbeeken nbbeeken merged commit 26ccb55 into main Mar 11, 2025
8 checks passed
@nbbeeken nbbeeken deleted the NODE-6756 branch March 11, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants