-
Notifications
You must be signed in to change notification settings - Fork 258
test(NODE-6756): add tags to benchmarks #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Feb 27, 2025
W-A-James
commented
Feb 27, 2025
W-A-James
commented
Feb 27, 2025
W-A-James
commented
Feb 27, 2025
W-A-James
commented
Feb 27, 2025
W-A-James
commented
Feb 27, 2025
W-A-James
commented
Feb 27, 2025
nbbeeken
suggested changes
Feb 28, 2025
The granular benchmarks timed out after 15min, it says the base commit takes 5min which I find a bit surprising, did we accidentally change iterations here? and should we do it intentionally later for a larger sample size? 😅 |
nbbeeken
suggested changes
Mar 7, 2025
nbbeeken
suggested changes
Mar 7, 2025
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
evergreen retry |
nbbeeken
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
getTypeTestTags
andgetMixedTestTags
helperIs there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript