Skip to content

perf: refactor bit operations into helper functions #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2024
Merged

perf: refactor bit operations into helper functions #652

merged 2 commits into from
Feb 27, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Add number bytewise get and set utils

Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • Instead of repeating bit shifting work throughout the serializer and deserializer we can consolidate the operations to helper utils that work across web and node
  • These utils employ bit shifting operations which are more performant than using a DataView

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 922792a into NODE-5934-readDoubleLE Feb 27, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-5934-consolidate-bit-work branch February 27, 2024 18:46
nbbeeken added a commit that referenced this pull request Feb 27, 2024
@nbbeeken
perf: refactor bit operations into helper functions (#652)
0eb9216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-khare-mongoDB aditi-khare-mongoDB Awaiting requested review from aditi-khare-mongoDB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @aditi-khare-mongoDB