This repository was archived by the owner on Mar 5, 2024. It is now read-only.
(DOCSP-5700): Updated MongoDB Agent banner. #297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmalliso
suggested changes
May 29, 2019
Contributor
schmalliso
left a comment
schmalliso
left a comment
There was a problem hiding this comment.
I think the alert could be clearer if rephrased, but from a theme perspective, this is sound.
themes/mms-cloud/page.html
Outdated
| Monitoring, Backup and Automation are merging to become | ||
| the MongoDB Agent. | ||
| <h4 class="alert-heading" style="margin-bottom: 10px;">The MongoDB Agent has been released!</h4> | ||
| Monitoring, Backup and Automation are now the MongoDB Agent. |
Contributor
There was a problem hiding this comment.
This doesn't make sense if you haven't seen the previous alert and fill in that we're referring to the old agents. It might be practical to clarify with something like The Monitoring, Backup, and Automation Agents have been replaced by the MongoDB Agent. Or something.
schmalliso
approved these changes
May 29, 2019
Contributor
schmalliso
left a comment
schmalliso
left a comment
There was a problem hiding this comment.
LGTM. Lemme know when you want me to merge it!
Contributor
|
Merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schmalliso : Just updating the MongoDB Agent banner to be more timely.