This repository was archived by the owner on Mar 5, 2024. It is now read-only.
DOCSP-4263 Rollup standalone feedback widget #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new css and js target for the feedback widget alone, so that it can be consumed by SDK generated docs themes. The entry point directory main/ is created so that entrypoints are not globbed into each others' bundles. Specifically, the new feedbackController.js would be globbed into the controller.js bundle.
i80and
approved these changes
Feb 5, 2019
Contributor
i80and
left a comment
i80and
left a comment
There was a problem hiding this comment.
lgtm! I think we should rename js/ at some point, but for now it's fine!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new css and js target for the feedback widget alone,
so that it can be consumed by SDK generated docs themes.
The entry point directory main/ is created so that entrypoints
are not globbed into each others' bundles. Specifically, the new
feedbackController.js would be globbed into the controller.js bundle.