Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests & snippets for sync session #3334

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

MongoCaleb
Copy link
Collaborator

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOCSP-40247

Staged Page
n/a

New snippet locations

Get sync session
source/examples/generated/dotnet/DataSyncExamples.snippet.get-sync-session.cs

Check sync state
source/examples/generated/dotnet/DataSyncExamples.snippet.get-session-state.cs

Upload and Download Progress
source/examples/generated/dotnet/ProgressNotifications.snippet.upload-download-progress-notification.cs

@MongoCaleb MongoCaleb requested a review from dacharyc July 22, 2024 22:55
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit efaee31
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/669fd72b8cc82a00087c71f1
😎 Deploy Preview https://deploy-preview-3334--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 23 (🔴 down 8 from production)
Accessibility: 93 (no change from production)
Best Practices: 75 (no change from production)
SEO: 69 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples are exactly what I'm looking for - thank you! But it looks like the .NET test suite is failing for some reason. Is it possible to get that fixed up? I'd prefer not to merge something into the consolidation branch that is going to show as a failing check on the branch.

Otherwise, I guess I can add these examples after merging the consolidated branch.

Copy link

Readability for Commit Hash: efaee31

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/dotnet/sync/sync-session: Grade Level: 4.4, Reading Ease: 79.26

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

@MongoCaleb MongoCaleb requested a review from dacharyc July 23, 2024 16:47
@dacharyc dacharyc added the Add to consolidation feature branch PR merged after cutting the consolidation feature branch, so cherry-pick to the feature branch. label Jul 23, 2024
Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you for fixing up the test failures. LGTM!

@MongoCaleb MongoCaleb merged commit 60f6a06 into mongodb:master Jul 23, 2024
11 checks passed
@MongoCaleb MongoCaleb deleted the DOCSP-40247 branch July 23, 2024 18:44
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add to consolidation feature branch PR merged after cutting the consolidation feature branch, so cherry-pick to the feature branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants