-
Notifications
You must be signed in to change notification settings - Fork 88
(DOCSP-39513): Consolidate Create page #3270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39513): Consolidate Create page #3270
Conversation
Readability for Commit Hash: 19b0f29 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to review Create Property Types
, but figured there's plenty of feedback for you to sift through so sorry
source/sdk/crud.txt
Outdated
@@ -15,7 +15,7 @@ Read and Write Data | |||
The following pages contain information about how to read and write data, | |||
manage objects across threads, and use the Atlas Device SDK query engines: | |||
|
|||
- :ref:`sdks-crud-create` | |||
- :ref:`sdks-create-object-methods` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be updated now that the consolidated page is split into 3 child pages under Create?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I've changed this back to sdks-crud-create
after moving this back to a container page with content - i.e. a landing page. So this can be the main destination for "create" content.
.. _sdks-create-object-methods: | ||
|
||
===================== | ||
Create Object Methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] This feels out of place with the two other child page titles. plus the "methods" renders the title a noun instead of an action, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capturing this detail on the PR in case there are questions in the future. Cory and I discussed this offline and decided to try it with this page as a parent page called "Create Objects" and the other two pages as child pages, instead of the three being sibling pages. We can change this in the future if we decide this is a pattern we don't want to use (the create methods as the landing page) - we can revisit before we merge the feature branch and move the content if we need to.
:ref:`sdks-configure-and-open-database` or | ||
:ref:`sdks-configure-and-open-synced-database`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[note] it's really hard to parse these two links in the rendered text since these page titles are very nearly identical
@@ -11,6 +11,7 @@ You can also return values from the write transaction callback function. | |||
|
|||
.. warning:: Write RealmObjects to One Realm File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this unique to the Flutter SDK? if so, should we make that clear? it seems potentially confusing to see this big red warning that seems potentially applicable to other sdks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception type is probably specific to Flutter. But the general info applies to more than one SDK - I know, for example, in Swift the DB throws an error if you try to write an object to a DB that is already managed by another DB.
We do explain that in the "Managed Objects" section, with a link to the section on copying a managed object to another DB. So maybe this warning isn't needed? I'll have a think about it.
For more information about modeling an object, refer to: | ||
:ref:`sdks-object-models`. | ||
|
||
.. include:: /includes/sdk-examples/crud/create-realm-object-model.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - we should models for all of the Kotlin examples, so these should be easy to pop in as part of the follow-up tickets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job, @dacharyc. This was a tremendous amount of work. I'm sorry it took me so long to finish my review!
~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Like their native counterparts, the SDK's set data type stores unique values. | ||
These values may be of any supported type except another collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Kotlin, they can't contain an embedded object either
source/includes/api-details/java/crud/create-counter-property-type-java-description.rst
Outdated
Show resolved
Hide resolved
@@ -0,0 +1 @@ | |||
JavaScript does not currently have a dedicated counter property type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does now! 🥳 the new page should be available to merge to the feature branch this week
Co-authored-by: cbullinger <115956901+cbullinger@users.noreply.github.com>
ae0e146
into
mongodb:feature-consolidated-sdk-docs
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/feature-consolidated-sdk-docs/ 🪵 Logs |
Pull Request Info - SDK Docs Consolidation
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39513
Staged Page
New consolidated pages:
Existing pages, ported over to the consolidated IA and updated for product naming/metadata:
Page Source
Add links to every SDK's pages where you got the SDK-specific information:
PR Author Checklist
Before requesting a review for your PR, please check these items:
feature-consolidated-sdk-docs
branch instead ofmaster
Naming
.rst
files comply with the naming guidelinesNote for Reviewer: The
.rst
files were named for a single create page. Having split the create page into 3, the names no longer comply with the guidelines. As this is around ~140 files, I didn't want to rename them all - but we may want to consider whether I should go through the effort, and/or what the naming guidelines look like as the IA evolves.Links and Refs
Content
Reviewer Checklist
As a reviewer, please check these items: