Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-39161 .NET updateBaseURL #3246

Merged
merged 15 commits into from
May 20, 2024
Merged

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented May 6, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • .NET SDK
    • Application Services/Connect to an App Services App: Add a section on updating the base URL during runtime.

Review Guidelines

REVIEWING.md

Copy link

github-actions bot commented May 7, 2024

Readability for Commit Hash: 5c391a7

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/dotnet/app-services/connect-to-app-services-backend: Grade Level: 9.1, Reading Ease: 56.45

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work on this!

@lindseymoore lindseymoore merged commit 0c633d6 into mongodb:master May 20, 2024
6 checks passed
@docs-builder-bot
Copy link

@dacharyc dacharyc added the Add to consolidation feature branch PR merged after cutting the consolidation feature branch, so cherry-pick to the feature branch. label May 21, 2024

This API is experimental. As seen above, you must use ``#pragma warning disable Rlm001``
and ``#pragma warning restore Rlm001`` to suppress the experimental errors,
where ``Rlm001`` is the experimental attributes's ``diagnosticId``. You must
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you, but I don't think you need to specify that is the diagnosticId

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to leave in for context.

and ``#pragma warning restore Rlm001`` to suppress the experimental errors,
where ``Rlm001`` is the experimental attributes's ``diagnosticId``. You must
also import the following namespace at the top of your file, which contains
the ``Experimental`` attribute:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add this namespace

cbullinger pushed a commit to cbullinger/docs-realm that referenced this pull request May 21, 2024
## Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161

- [Connect to App Services
Backend](https://preview-mongodblindseymoore.gatsbyjs.io/realm/DOCSP-39161/sdk/dotnet/app-services/connect-to-app-services-backend/)

- Note: Commented out failing tests. Fixing them will be a part of this
ticket: https://jira.mongodb.org/browse/DOCSP-39638.

### Reminder Checklist

Before merging your PR, make sure to check a few things.

- [ ] Did you tag pages appropriately?
  - genre
  - meta.keywords
  - meta.description
- [x] Describe your PR's changes in the Release Notes section
- [ ] Create a Jira ticket for related docs-app-services work, if any

### Release Notes

<!--
- **Kotlin** SDK
- Realm/Manage Realm Files/Encrypt a Realm: Add information on
encryption for
    local and synced realms.
-->

- .NET SDK
- Application Services/Connect to an App Services App: Add a section on
updating the base URL during runtime.

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

---------

Co-authored-by: MongoCaleb <caleb.thompson@mongodb.com>
@lindseymoore
Copy link
Collaborator Author

@papafe Thank you for the review! Addressed the last comment in this PR here: #3267.

dacharyc pushed a commit that referenced this pull request May 21, 2024
## Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161

- [Connect to App Services
Backend](https://preview-mongodblindseymoore.gatsbyjs.io/realm/DOCSP-39161/sdk/dotnet/app-services/connect-to-app-services-backend/)

- Note: Commented out failing tests. Fixing them will be a part of this
ticket: https://jira.mongodb.org/browse/DOCSP-39638.

### Reminder Checklist

Before merging your PR, make sure to check a few things.

- [ ] Did you tag pages appropriately?
  - genre
  - meta.keywords
  - meta.description
- [x] Describe your PR's changes in the Release Notes section
- [ ] Create a Jira ticket for related docs-app-services work, if any

### Release Notes

<!--
- **Kotlin** SDK
- Realm/Manage Realm Files/Encrypt a Realm: Add information on
encryption for
    local and synced realms.
-->

- .NET SDK
- Application Services/Connect to an App Services App: Add a section on
updating the base URL during runtime.

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

---------

Co-authored-by: MongoCaleb <caleb.thompson@mongodb.com>
dacharyc pushed a commit to dacharyc/docs-realm that referenced this pull request May 21, 2024
## Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161

- [Connect to App Services
Backend](https://preview-mongodblindseymoore.gatsbyjs.io/realm/DOCSP-39161/sdk/dotnet/app-services/connect-to-app-services-backend/)

- Note: Commented out failing tests. Fixing them will be a part of this
ticket: https://jira.mongodb.org/browse/DOCSP-39638.

### Reminder Checklist

Before merging your PR, make sure to check a few things.

- [ ] Did you tag pages appropriately?
  - genre
  - meta.keywords
  - meta.description
- [x] Describe your PR's changes in the Release Notes section
- [ ] Create a Jira ticket for related docs-app-services work, if any

### Release Notes

<!--
- **Kotlin** SDK
- Realm/Manage Realm Files/Encrypt a Realm: Add information on
encryption for
    local and synced realms.
-->

- .NET SDK
- Application Services/Connect to an App Services App: Add a section on
updating the base URL during runtime.

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

---------

Co-authored-by: MongoCaleb <caleb.thompson@mongodb.com>
dacharyc pushed a commit that referenced this pull request Jun 24, 2024
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161

- [Connect to App Services
Backend](https://preview-mongodblindseymoore.gatsbyjs.io/realm/DOCSP-39161/sdk/dotnet/app-services/connect-to-app-services-backend/)

- Note: Commented out failing tests. Fixing them will be a part of this
ticket: https://jira.mongodb.org/browse/DOCSP-39638.

Before merging your PR, make sure to check a few things.

- [ ] Did you tag pages appropriately?
  - genre
  - meta.keywords
  - meta.description
- [x] Describe your PR's changes in the Release Notes section
- [ ] Create a Jira ticket for related docs-app-services work, if any

<!--
- **Kotlin** SDK
- Realm/Manage Realm Files/Encrypt a Realm: Add information on
encryption for
    local and synced realms.
-->

- .NET SDK
- Application Services/Connect to an App Services App: Add a section on
updating the base URL during runtime.

[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)

---------

Co-authored-by: MongoCaleb <caleb.thompson@mongodb.com>
@dacharyc dacharyc removed the Add to consolidation feature branch PR merged after cutting the consolidation feature branch, so cherry-pick to the feature branch. label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants