-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-37240: Add upgrade page for Flutter SDK v2.0.0 breaking changes #3196
DOCSP-37240: Add upgrade page for Flutter SDK v2.0.0 breaking changes #3196
Conversation
Readability for Commit Hash: f0fa565 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
df3d0d6
to
5da5a72
Compare
5da5a72
to
b799f71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just a few suggestion regarding the actual PR.
However, unrelated to this PR, but spotted while reviewing:
- Minimal flutter and dart version was downgraded to 3.10.0 and 3.0.0 in a previous release.
- The comments about 2.17.x are obsolete, given the 3.10.0 requirement.
- We don't support Windows on Arm, similar to Linux. We should perhaps clarify that.
e24a053
to
57983c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for adding links, otherwise LGTM! Great work :)
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/master/ 🪵 Logs |
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-37240
.g.dart
file extensions to.realm.dart
throughout page..g.dart
file extensions to.realm.dart
throughout page..g.dart
file extensions to.realm.dart
throughout page.Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
.g.dart
file extensions to the new.realm.dart
extension throughout the SDK documentation.Review Guidelines
REVIEWING.md