-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-31536) Update RN quick start #3141
Conversation
- Create examples - Generate snippets - Update quickstart content
- Create - Update - Delete
- Update sync content - Reorganize a bit of content
Readability for Commit Hash: 545a3c2 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
examples/react-native/v12/TestApp/src/components/quickstart/nonsync/RealmWrapper.test.tsx
Outdated
Show resolved
Hide resolved
examples/react-native/v12/TestApp/src/components/quickstart/nonsync/RealmWrapper.test.tsx
Outdated
Show resolved
Hide resolved
examples/react-native/v12/TestApp/src/components/quickstart/nonsync/RealmWrapper.test.tsx
Outdated
Show resolved
Hide resolved
import {useQuery} from '@realm/react'; | ||
import {Profile} from '../../models'; | ||
|
||
export const Read = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
:emphasize-lines: 41-47, 54-60 | ||
Instead, you can use :js-sdk:`Realm.objects <classes/Realm-1.html#objects>` for | ||
collections or :js-sdk:`Realm.objectForPrimaryKey | ||
<classes/Realm-1.html#objectForPrimaryKey>` a single object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to link to the Read page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should! Thanks for suggesting.
#. Pass your object models to the ``schema`` prop. | ||
#. Add other :realm-react-sdk:`Configuration object <types/Realm.BaseConfiguration.html>` | ||
properties as props to ``RealmProvider``. For example, make the realm read | ||
only or add Atlas Device Sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, make the realm read only or <something else that isn't Device Sync>.
?
IDK why this is bugging me, but maybe omit since "adding Device Sync" isn't equivalent to passing a read-only parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looking at it now, I don't think this sentence adds much. I'll remove the whole thing.
Co-authored-by: cbullinger <115956901+cbullinger@users.noreply.github.com>
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/master/ 🪵 Logs |
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-31536
@realm/react
conventions.Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
@realm/react
conventions and Realm.js v12 features.Review Guidelines
REVIEWING.md
Animal Wearing a Hat