-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-31531): NET SDK Migrate PBS to FS updates #2916
Conversation
Readability for Commit Hash: b6bb305 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with some open questions. Overall looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments
#. Create a | ||
:dotnet-sdk:`PartitionSyncConfiguration <reference/Realms.Sync.PartitionSyncConfiguration.html>` | ||
object that includes the :ref:`partition name <partition-value>` and | ||
the :dotnet-sdk:`User <reference/Realms.Sync.User.html>` object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the snippet is included in this PR, but in the snippet it catches the RealmFileAccessErrorException
. It should catch a generic Exception
, since there are multiple errors that can be raised at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - updated this example. Thank you!
source/examples/generated/dotnet-flexible-sync/FlexibleSyncExamples.snippet.open-fs-realm.cs
Outdated
Show resolved
Hide resolved
...xamples/generated/dotnet-flexible-sync/FlexibleSyncExamples.snippet.open-fs-realm-offline.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments here and there
Looks good! |
8a8e50b
to
382bf26
Compare
✨ Staging URL: https://docs-mongodborg-staging.corp.mongodb.com/realm/docsworker-xlarge/master/ 🪵 Logs |
## Pull Request Info ### Jira - https://jira.mongodb.org/browse/DOCSP-31531 ### Staged Changes - [Sync Data](https://docs-mongodbcom-staging.corp.mongodb.com/realm/docsworker-xlarge/DOCSP-31531/sdk/dotnet/sync/): Remove PBS info - [Configure & Open a Synced Realm](https://docs-mongodbcom-staging.corp.mongodb.com/realm/docsworker-xlarge/DOCSP-31531/sdk/dotnet/sync/configure-and-open-a-synced-realm/): Remove PBS info to new PBS page. Add new Flexible Sync code examples for opening a realm. The other examples on this page should also be updated to show FS instead of PBS, but aren't necessarily a blocker for this PR. - [Partition-Based Sync](https://docs-mongodbcom-staging.corp.mongodb.com/realm/docsworker-xlarge/DOCSP-31531/sdk/dotnet/sync/partition-based-sync/): New page with moved PBS content and new migration info ### Reminder Checklist If your PR modifies the docs, you might need to also update some corresponding pages. Check if completed or N/A. - [x] Create Jira ticket for corresponding docs-app-services update(s), if any - [x] Checked/updated Admin API - [x] Checked/updated CLI reference ### Review Guidelines [REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)
Pull Request Info
Jira
Staged Changes
Reminder Checklist
If your PR modifies the docs, you might need to also update some corresponding
pages. Check if completed or N/A.
Review Guidelines
REVIEWING.md