Skip to content

DOCSP-46751 change title in PHP library docs to avoid duplicate #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shuangela
Copy link
Collaborator

@shuangela shuangela commented Feb 26, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46751
Staging - https://deploy-preview-208--docs-php-library.netlify.app/get-started/run-sample-query/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit 9215f3a
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/67c0eb135b240f0008b318bb
😎 Deploy Preview https://deploy-preview-208--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shuangela shuangela requested a review from sarahemlin February 26, 2025 21:12
Copy link
Collaborator

@sarahemlin sarahemlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New URL + redirect needed! Thx!

Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you fix the link redirect before merging

config/redirects Outdated
@@ -8,6 +8,7 @@ symlink: current -> v1.20
# general redirects
[v1.17-v1.19]: ${prefix}/${version}/tutorial/client-side-encryption/ -> ${base}/${version}/tutorial/encryption/
[v1.16]: ${prefix}/${version}/tutorial/encryption/ -> ${base}/${version}/
[v1.20-*]: ${prefix}/${version}/get-started/connect-to-mongodb -> ${base}/get-started/run-sample-query/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[v1.20-*]: ${prefix}/${version}/get-started/connect-to-mongodb -> ${base}/get-started/run-sample-query/
[v1.20-*]: ${prefix}/${version}/get-started/connect-to-mongodb -> ${base}/${version}/get-started/run-sample-query/

@shuangela shuangela merged commit 22e71d1 into mongodb:master Feb 28, 2025
5 checks passed
Copy link

The backport to v1.20 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.20 v1.20
# Navigate to the new working tree
cd .worktrees/backport-v1.20
# Create a new branch
git switch --create backport-208-to-v1.20
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 22e71d14a55ce1f22799227ed52e9ba328315a45
# Push it to GitHub
git push --set-upstream origin backport-208-to-v1.20
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.20

Then, create a pull request where the base branch is v1.20 and the compare/head branch is backport-208-to-v1.20.

shuangela added a commit to shuangela/docs-php-library that referenced this pull request Feb 28, 2025
…ect-duplicate-title

DOCSP-46751 change title in PHP library docs to avoid duplicate

(cherry picked from commit 22e71d1)

cherry pick backport
shuangela added a commit that referenced this pull request Feb 28, 2025
Merge pull request #208 from shuangela/DOCSP-46751-change-connect-dup…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants