Skip to content

DOCSP-45431: php 7.2 in lang compat #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Nov 19, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45431
Staging - https://deploy-preview-180--docs-php-library.netlify.app/compatibility/#language-compatibility

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit c4dc353
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/673cd56f8a2d2f0008f4343a
😎 Deploy Preview https://deploy-preview-180--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bisht2050
Copy link
Collaborator

bisht2050 commented Nov 19, 2024

Would this update https://www.mongodb.com/docs/drivers/php-drivers/#language-compatibility as well?
The staging preview link is only for https://www.mongodb.com/docs/php-library/current/compatibility/ hence wanted to double check.

@rustagir
Copy link
Collaborator Author

@bisht2050 yes, that table (source file) uses the shared include. Unfortunately, the docs platform team is investigating an issue with shared includes, so they might render incorrectly atm but they are actively investigating.

Copy link
Collaborator

@bisht2050 bisht2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@rustagir rustagir merged commit 1b08539 into mongodb:master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants