-
Notifications
You must be signed in to change notification settings - Fork 19
DOCSP-50017 Remove EOL versions #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-kotlin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes mainly for the suggestion I made about the auth page!
source/fundamentals/auth.txt
Outdated
@@ -52,16 +52,7 @@ Mechanisms | |||
Default | |||
~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Instead of having separate "Default" and "SCRAM-SHA-256" section, I think it makes sense to combine them. I did that in the kotlin sync PR, which should be basically the same. Otherwise if you do want to keep them separate I'd delete the note about server versions from line 105-108
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I forgot to save and commit my auth page changes. But will combine the sections, thanks for the suggestion!
source/fundamentals/auth.txt
Outdated
@@ -52,16 +52,7 @@ Mechanisms | |||
Default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: I can't comment on the line directly, but you can remove * :ref:MONGODB-CR <mongodb-cr-auth-mechanism>
from the list in the overview (and any other references to that ref in the docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + one suggestion!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.2 v5.2
# Navigate to the new working tree
cd .worktrees/backport-v5.2
# Create a new branch
git switch --create backport-220-to-v5.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
# Push it to GitHub
git push --set-upstream origin backport-220-to-v5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.1 v5.1
# Navigate to the new working tree
cd .worktrees/backport-v5.1
# Create a new branch
git switch --create backport-220-to-v5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
# Push it to GitHub
git push --set-upstream origin backport-220-to-v5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.0 v5.0
# Navigate to the new working tree
cd .worktrees/backport-v5.0
# Create a new branch
git switch --create backport-220-to-v5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
# Push it to GitHub
git push --set-upstream origin backport-220-to-v5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.3 v5.3
# Navigate to the new working tree
cd .worktrees/backport-v5.3
# Create a new branch
git switch --create backport-220-to-v5.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
# Push it to GitHub
git push --set-upstream origin backport-220-to-v5.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v5.4 v5.4
# Navigate to the new working tree
cd .worktrees/backport-v5.4
# Create a new branch
git switch --create backport-220-to-v5.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
# Push it to GitHub
git push --set-upstream origin backport-220-to-v5.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v5.4 Then, create a pull request where the |
* DOCSP-50017 Remove EOL versions * auth * auth suggestion NR * NR comments * get rid of font on headings (cherry picked from commit 94fd075)
* DOCSP-50017 Remove EOL versions * auth * auth suggestion NR * NR comments * get rid of font on headings (cherry picked from commit 94fd075) (cherry picked from commit 7046a65) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit f2237b0)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-50017
Staging Links
Self-Review Checklist