Skip to content

DOCSP-50017 Remove EOL versions #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented May 22, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50017

Staging Links

  • fundamentals/auth
  • fundamentals/builders/aggregates
  • fundamentals/builders/projections
  • fundamentals/connection/network-compression
  • fundamentals/crud/read-operations/sort
  • fundamentals/enterprise-auth
  • fundamentals/indexes
  • fundamentals/stable-api
  • fundamentals/time-series
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented May 22, 2025

    Deploy Preview for docs-kotlin ready!

    Name Link
    🔨 Latest commit c53dbef
    🔍 Latest deploy log https://app.netlify.com/projects/docs-kotlin/deploys/682fcc693e3b350008944acb
    😎 Deploy Preview https://deploy-preview-220--docs-kotlin.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Requesting changes mainly for the suggestion I made about the auth page!

    @@ -52,16 +52,7 @@ Mechanisms
    Default
    ~~~~~~~
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: Instead of having separate "Default" and "SCRAM-SHA-256" section, I think it makes sense to combine them. I did that in the kotlin sync PR, which should be basically the same. Otherwise if you do want to keep them separate I'd delete the note about server versions from line 105-108

    Copy link
    Collaborator Author

    @lindseymoore lindseymoore May 22, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ahh I forgot to save and commit my auth page changes. But will combine the sections, thanks for the suggestion!

    @@ -52,16 +52,7 @@ Mechanisms
    Default
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I: I can't comment on the line directly, but you can remove * :ref:MONGODB-CR <mongodb-cr-auth-mechanism> from the list in the overview (and any other references to that ref in the docs)

    @lindseymoore lindseymoore requested a review from norareidy May 22, 2025 20:45
    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM + one suggestion!

    @lindseymoore lindseymoore merged commit 94fd075 into mongodb:master May 23, 2025
    12 of 13 checks passed
    Copy link

    The backport to v5.2 failed:

    The process '/usr/bin/git' failed with exit code 1
    

    To backport manually, run these commands in your terminal:

    # Fetch latest updates from GitHub
    git fetch
    # Create a new working tree
    git worktree add .worktrees/backport-v5.2 v5.2
    # Navigate to the new working tree
    cd .worktrees/backport-v5.2
    # Create a new branch
    git switch --create backport-220-to-v5.2
    # Cherry-pick the merged commit of this pull request and resolve the conflicts
    git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
    # Push it to GitHub
    git push --set-upstream origin backport-220-to-v5.2
    # Go back to the original working tree
    cd ../..
    # Delete the working tree
    git worktree remove .worktrees/backport-v5.2

    Then, create a pull request where the base branch is v5.2 and the compare/head branch is backport-220-to-v5.2.

    Copy link

    The backport to v5.1 failed:

    The process '/usr/bin/git' failed with exit code 1
    

    To backport manually, run these commands in your terminal:

    # Fetch latest updates from GitHub
    git fetch
    # Create a new working tree
    git worktree add .worktrees/backport-v5.1 v5.1
    # Navigate to the new working tree
    cd .worktrees/backport-v5.1
    # Create a new branch
    git switch --create backport-220-to-v5.1
    # Cherry-pick the merged commit of this pull request and resolve the conflicts
    git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
    # Push it to GitHub
    git push --set-upstream origin backport-220-to-v5.1
    # Go back to the original working tree
    cd ../..
    # Delete the working tree
    git worktree remove .worktrees/backport-v5.1

    Then, create a pull request where the base branch is v5.1 and the compare/head branch is backport-220-to-v5.1.

    Copy link

    The backport to v5.0 failed:

    The process '/usr/bin/git' failed with exit code 1
    

    To backport manually, run these commands in your terminal:

    # Fetch latest updates from GitHub
    git fetch
    # Create a new working tree
    git worktree add .worktrees/backport-v5.0 v5.0
    # Navigate to the new working tree
    cd .worktrees/backport-v5.0
    # Create a new branch
    git switch --create backport-220-to-v5.0
    # Cherry-pick the merged commit of this pull request and resolve the conflicts
    git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
    # Push it to GitHub
    git push --set-upstream origin backport-220-to-v5.0
    # Go back to the original working tree
    cd ../..
    # Delete the working tree
    git worktree remove .worktrees/backport-v5.0

    Then, create a pull request where the base branch is v5.0 and the compare/head branch is backport-220-to-v5.0.

    Copy link

    The backport to v5.3 failed:

    The process '/usr/bin/git' failed with exit code 1
    

    To backport manually, run these commands in your terminal:

    # Fetch latest updates from GitHub
    git fetch
    # Create a new working tree
    git worktree add .worktrees/backport-v5.3 v5.3
    # Navigate to the new working tree
    cd .worktrees/backport-v5.3
    # Create a new branch
    git switch --create backport-220-to-v5.3
    # Cherry-pick the merged commit of this pull request and resolve the conflicts
    git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
    # Push it to GitHub
    git push --set-upstream origin backport-220-to-v5.3
    # Go back to the original working tree
    cd ../..
    # Delete the working tree
    git worktree remove .worktrees/backport-v5.3

    Then, create a pull request where the base branch is v5.3 and the compare/head branch is backport-220-to-v5.3.

    Copy link

    The backport to v5.4 failed:

    The process '/usr/bin/git' failed with exit code 1
    

    To backport manually, run these commands in your terminal:

    # Fetch latest updates from GitHub
    git fetch
    # Create a new working tree
    git worktree add .worktrees/backport-v5.4 v5.4
    # Navigate to the new working tree
    cd .worktrees/backport-v5.4
    # Create a new branch
    git switch --create backport-220-to-v5.4
    # Cherry-pick the merged commit of this pull request and resolve the conflicts
    git cherry-pick -x --mainline 1 94fd075a3dc034aaa464b665aa89094fb23bf8e5
    # Push it to GitHub
    git push --set-upstream origin backport-220-to-v5.4
    # Go back to the original working tree
    cd ../..
    # Delete the working tree
    git worktree remove .worktrees/backport-v5.4

    Then, create a pull request where the base branch is v5.4 and the compare/head branch is backport-220-to-v5.4.

    github-actions bot pushed a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    lindseymoore added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    lindseymoore added a commit to lindseymoore/docs-kotlin that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    (cherry picked from commit 7046a65)
    lindseymoore added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    
    (cherry picked from commit 7046a65)
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    lindseymoore added a commit to lindseymoore/docs-kotlin that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    (cherry picked from commit 7046a65)
    lindseymoore added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    
    (cherry picked from commit 7046a65)
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions bot added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    (cherry picked from commit 7046a65)
    
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    (cherry picked from commit f2237b0)
    lindseymoore added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    (cherry picked from commit 7046a65)
    lindseymoore added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    (cherry picked from commit 7046a65)
    lindseymoore added a commit that referenced this pull request May 23, 2025
    * DOCSP-50017 Remove EOL versions
    
    * auth
    
    * auth suggestion NR
    
    * NR comments
    
    * get rid of font on headings
    
    (cherry picked from commit 94fd075)
    
    Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
    (cherry picked from commit 7046a65)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants