-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-37757-add-regex-info #731
DOCSP-37757-add-regex-info #731
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shuangela, LGTM! One small optional suggestion
To learn more about syntax for ``pattern`` and ``options`` for regular | ||
expression filtering, see :ref:`c2c-filter-regex`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional / suggestion] (brevity)
Optional edit to trim this sentence by a couple of words
To learn more about syntax for ``pattern`` and ``options`` for regular | |
expression filtering, see :ref:`c2c-filter-regex`. | |
To learn more about the ``pattern`` and ``options`` regular expression syntax, see :ref:`c2c-filter-regex`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the notes here, it seems advantageous also to give examples, esp. of a case with multiple regexp options.
@@ -36,6 +36,61 @@ you can use regular expressions: | |||
} | |||
} | |||
|
|||
The regular expression pattern you pass into a filter must follow the :query:`regex <$regex>` syntax supported by the MongoDB server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just link to the server’s own regexp docs? That seems better than duplicating the information here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The :query:regex <$regex>
section does link out to the server's own regex docs, but I can also remove the options section and also link out to the server regex docs as the options are the same as the server regex docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To address your overarching comment about adding an example, there is an example on the filter-regex page of matching with multiple regex options, but I tried to make the lead in text clearer for it and added a better title to make that more clear.
@@ -36,6 +36,61 @@ you can use regular expressions: | |||
} | |||
} | |||
|
|||
The regular expression pattern you pass into a filter must follow the :query:`regex <$regex>` syntax supported by the MongoDB server. | |||
|
|||
Regular expressions in filter documents use the following ``options``: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’d be good to clarify that options
is a string of concatenated options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
* add regex info * change wording * expression * wording * jw feedback * add information * add info * info * remove options (cherry picked from commit e9b2180)
* add regex info * change wording * expression * wording * jw feedback * add information * add info * info * remove options (cherry picked from commit e9b2180)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* add regex info * change wording * expression * wording * jw feedback * add information * add info * info * remove options (cherry picked from commit e9b2180)
DESCRIPTION
Adds details on regex syntax in c2c
STAGING
https://deploy-preview-731--docs-cluster-to-cluster-sync.netlify.app/reference/collection-level-filtering/
https://deploy-preview-731--docs-cluster-to-cluster-sync.netlify.app/reference/collection-level-filtering/filter-regex/
JIRA
https://jira.mongodb.org/browse/DOCSP-37757
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?