RUST-1406 Convert serde errors to standard error type #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
serde-errors
branch
from
ac4ec3a to
6f35184
Compare
isabelatkinson
commented
Jun 27, 2025
| Self::DeserializationError { | ||
| message: err.to_string(), | ||
| } | ||
| fn from(error: serde_json::Error) -> Self { |
There was a problem hiding this comment.
I kept this From impl in the public API because we're already exposing a bunch of serde_json conversions below. It might be worth putting all of the serde_json stuff behind the serde feature flag or giving it its own flag - if that makes sense I'll file a separate ticket.
| fn serialize_bool(self, v: bool) -> Result<Self::Ok> { | ||
| Err(Self::invalid_key(v)) | ||
| fn serialize_bool(self, _v: bool) -> Result<Self::Ok> { | ||
| Err(Error::invalid_key_type("bool")) |
There was a problem hiding this comment.
This is a deviation from the current API, which stores the invalid key as Bson. This leads to some weird placeholders (empty arrays and documents, Bson::Null if conversion fails). I think a string message that reports the bad type is sufficient here, and users can turn on serde_path_to_error for more detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of the conversions.