RUST-1753: Add a utility HumanReadable wrapper #431
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1753
I propose that instead of adding an explicit option to
Collection
to force on human-readable [de]serialization, we provide a type wrapper that does the same thing. This should provide equivalent functionality (instead of settingopts.human_readable_serialization = true
for a givenCollection<Foo>
, specify the type asCollection<HumanReadable<Foo>>
), but means that we don't have to support checking the explicit option in every relevant code path for every method. Subjectively, I also find this cleaner :)I put this in the
bson::serde_helpers
module because it's arguably independent of the driver; it's even arguably independent of bson, but I don't think we want to maintain another crate.If we do decide to use this, the path forward would be:
bson
crate with these helpers.beta.1
release of the driver with those changes.