Silence and ignore potential dos2unix conversion failures #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #260 (comment).
The invocation of
dos2unixis intended to workaround the as-of-yet unresolved issue with activation scripts generated by venv in Cygwin environments. Use ofdos2unixas a simple workaround improves the viability of using recent Python binaries and the venv module over virtualenv.Error handling was added to its invocation as part of #236. However, given this was observed to cause some friction during local development on Windows, this PR suggests silencing and ignoring potential
dos2unixfailures (as it had been done previously) in favor of allowing failure detection and handling in later stages of virtual environment use should they occur. This change is not expected to affect the scripts' behavior in Evergreen environments.As a minor improvement, copied over rationale for the workaround from venv-utils.sh into all instances of invoking
dos2unixfor visibility.