feat(data-browser): add setting to view documents in native VSCode editors VSCODE-776#1311
Open
Anemy wants to merge 7 commits into
Open
feat(data-browser): add setting to view documents in native VSCode editors VSCODE-776#1311Anemy wants to merge 7 commits into
Anemy wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new mdb.useWebViewDataBrowser setting that allows users to bypass the data browser webview and instead view collection documents / playground cursor results in native VS Code editors, aligning with the request in #1296.
Changes:
- Introduces
mdb.useWebViewDataBrowser(defaulttrue) and wires it into collection document viewing + playground cursor result handling. - Extends
DataBrowserOpenedTelemetryEventto record whether the setting is enabled, and adds new tracking when using the editor-based path. - Adds E2E coverage for the editor-based result display and supporting E2E helpers (settings mutation + reading editor content).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/dataBrowsingController.ts | Updates data-browser-open telemetry to include the new setting flag when opening the webview. |
| src/mdbExtensionController.ts | Routes “View Collection Documents” to either the webview data browser or the native editor based on the new setting; adds editor-path telemetry. |
| src/editors/playgroundController.ts | Uses the new setting to decide whether cursor results open in the webview data browser or in the editor result pane; adds telemetry for the editor path. |
| src/editors/types.ts | Adds getUseWebViewDataBrowser() helper for reading the new configuration. |
| src/telemetry/telemetryEvents.ts | Extends DataBrowserOpenedTelemetryEvent with a use_webview_data_browser property and updates docs accordingly. |
| src/test/e2e/helpers.ts | Adds helpers for updating user settings during tests and extracting editor text via clipboard; improves close-all-editors behavior with custom dialogs. |
| src/test/e2e/playground.test.ts | Adds an E2E test verifying cursor results open in a native editor when the setting is disabled. |
| src/mcp/mcpController.ts | Switches TelemetryService import to a type-only import. |
| package.json | Adds the mdb.useWebViewDataBrowser setting contribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
The brach missed some recent changes from main, maybe it causes types errors we see in CI. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSCODE-776
Issue #1296
Adds a new setting for bypassing the webview for viewing documents.