Skip to content

feat(data-browser): add setting to view documents in native VSCode editors VSCODE-776#1311

Open
Anemy wants to merge 7 commits into
mainfrom
VSCODE-776-add-setting-for-editor-data-browsing
Open

feat(data-browser): add setting to view documents in native VSCode editors VSCODE-776#1311
Anemy wants to merge 7 commits into
mainfrom
VSCODE-776-add-setting-for-editor-data-browsing

Conversation

@Anemy
Copy link
Copy Markdown
Member

@Anemy Anemy commented Jun 2, 2026

VSCODE-776
Issue #1296

Adds a new setting for bypassing the webview for viewing documents.

@Anemy Anemy requested a review from a team as a code owner June 2, 2026 19:45
Copilot AI review requested due to automatic review settings June 2, 2026 19:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new mdb.useWebViewDataBrowser setting that allows users to bypass the data browser webview and instead view collection documents / playground cursor results in native VS Code editors, aligning with the request in #1296.

Changes:

  • Introduces mdb.useWebViewDataBrowser (default true) and wires it into collection document viewing + playground cursor result handling.
  • Extends DataBrowserOpenedTelemetryEvent to record whether the setting is enabled, and adds new tracking when using the editor-based path.
  • Adds E2E coverage for the editor-based result display and supporting E2E helpers (settings mutation + reading editor content).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/views/dataBrowsingController.ts Updates data-browser-open telemetry to include the new setting flag when opening the webview.
src/mdbExtensionController.ts Routes “View Collection Documents” to either the webview data browser or the native editor based on the new setting; adds editor-path telemetry.
src/editors/playgroundController.ts Uses the new setting to decide whether cursor results open in the webview data browser or in the editor result pane; adds telemetry for the editor path.
src/editors/types.ts Adds getUseWebViewDataBrowser() helper for reading the new configuration.
src/telemetry/telemetryEvents.ts Extends DataBrowserOpenedTelemetryEvent with a use_webview_data_browser property and updates docs accordingly.
src/test/e2e/helpers.ts Adds helpers for updating user settings during tests and extracting editor text via clipboard; improves close-all-editors behavior with custom dialogs.
src/test/e2e/playground.test.ts Adds an E2E test verifying cursor results open in a native editor when the setting is disabled.
src/mcp/mcpController.ts Switches TelemetryService import to a type-only import.
package.json Adds the mdb.useWebViewDataBrowser setting contribution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/views/dataBrowsingController.ts
Comment thread src/test/e2e/playground.test.ts Outdated
Comment thread package.json Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread src/test/e2e/playground.test.ts Outdated
@alenakhineika
Copy link
Copy Markdown
Contributor

The brach missed some recent changes from main, maybe it causes types errors we see in CI.

Anemy and others added 3 commits June 4, 2026 07:05
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants