chore: update README to reflect current situation #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the main build script to actually set the right distribution variant value in the config, which had accidentally been broken (and so the example in the README wouldn’t work).
addaleax
changed the title
addaleax
changed the title
mcasimir
reviewed
Apr 28, 2021
| 1. Fork the repository on GitHub | ||
| 1. Create a branch with a name that briefly describes your feature | ||
| 1. Implement your feature or bug fix | ||
| 1. Add new test cases that verify your bug fix or make sure no one | ||
| unintentionally breaks your feature in the future and run them with `npm test` | ||
| - You can use `it.only()` instead of `it()` in mocha tests to run only a subset of tests. |
There was a problem hiding this comment.
we have an eslint rule that catches it if someone forget it in the PR right?
mcasimir
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the main build script to actually set the right
distribution variant value in the config, which had accidentally
been broken (and so the example in the README wouldn’t work).