feat(cli-repl): do not wait for log clean-up MONGOSH-1990 #2355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 4, 2025
addaleax
reviewed
Feb 4, 2025
addaleax
requested changes
Feb 4, 2025
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
markTime() needs to be moved
This comment was marked as spam.
This comment was marked as spam.
addaleax
approved these changes
Feb 4, 2025
gagik
approved these changes
Feb 4, 2025
gagik
pushed a commit
that referenced
this pull request
Feb 5, 2025
* feat(cli-repl): do not wait for log clean-up MONGOSH-1990 * test: add test for log manager throwing error * test: remove only * fix: mark time after log cleanup
gagik
pushed a commit
that referenced
this pull request
Feb 5, 2025
* feat(cli-repl): do not wait for log clean-up MONGOSH-1990 * test: add test for log manager throwing error * test: remove only * fix: mark time after log cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning up the old log files, we won’t wait for those processes to finish to unblock the main process. We will log errors if MongoLogManager throws any.