refactor: tool registration #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: chore: add LICENSE and fix version (#6)
gagik
reviewed
Apr 8, 2025
package.json
Outdated
| "check:format": "npx prettier -c .", | ||
| "reformat": "npx prettier -- --write ." | ||
| "check:lint": "eslint .", | ||
| "check:format": "npm run prettier -c .", |
There was a problem hiding this comment.
Suggested change
| "check:format": "npm run prettier -c .", | |
| "check:format": "prettier -c .", |
I think this should work
blva
reviewed
Apr 8, 2025
fmenezes
previously approved these changes
Apr 8, 2025
fmenezes
reviewed
Apr 8, 2025
| import { Transport } from "@modelcontextprotocol/sdk/shared/transport.js"; | ||
| import { z, ZodOptional, ZodString } from "zod"; | ||
| import { ApiClient, AtlasCluster } from "./client.js"; | ||
| import { ApiClient } from "./client.js"; |
There was a problem hiding this comment.
should we perhaps move client and all API stuff to AtlasToolBase? I think only atlas will use it
There was a problem hiding this comment.
telemetry will use it I think, which won't be atlas
There was a problem hiding this comment.
Hm... not super familiar with how we're going to be doing telemetry, so will leave it as is for now, but we can definitely move it over if it turns out it's not needed for telemetry.
* main: ci: publish to npm (#9) # Conflicts: # dist/client.js # dist/config.js # dist/index.js # dist/server.js # dist/state.js # package.json
blva
approved these changes
Apr 8, 2025
fmenezes
approved these changes
Apr 8, 2025
|
@nirinchev make sure to delete dist folder on your branch before merging |
gagik
reviewed
Apr 8, 2025
fmenezes
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the way tools are defined and registered:
Additionally, it adds a few QOL improvements: