chore: include tool args for perf advisor telemetry MCP-277

[nirinchev]

Proposed changes

Reworks telemetry events a bit - now we can provide arbitrary kvp data from resolveTelemetryMetadata in tools. This allows us to include the operations as additional field in properties. Additionally, renamed the fixed fields in TelemetryToolMetadata to match the names we're sending so we can just spread the object instead of the custom handling we had previously.

[Copilot]

Pull Request Overview

This PR refactors telemetry event handling to allow tools to include arbitrary key-value pairs in telemetry metadata, and disables telemetry in accuracy tests. The refactoring renames metadata fields to match the actual property names being sent (e.g., projectId → project_id), enabling direct spreading of metadata objects instead of manual property mapping.

Key changes:

• Extended TelemetryToolMetadata type to support arbitrary string/number/array properties via intersection type
• Renamed fixed telemetry metadata fields to match transmitted property names (projectId → project_id, etc.)
• Modified resolveTelemetryMetadata to accept result and args parameters for context-aware metadata
• Disabled telemetry in accuracy tests via DO_NOT_TRACK=1 environment variable

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tools/tool.ts	Extended TelemetryToolMetadata type and simplified event emission by spreading metadata directly instead of manual property assignment
src/tools/atlas/atlasTool.ts	Updated field names from projectId/orgId to project_id/org_id to match new naming convention
src/tools/mongodb/mongodbTool.ts	Updated projectId to project_id in metadata assignment
src/tools/atlasLocal/atlasLocalTool.ts	Updated atlasLocaldeploymentId to atlas_local_deployment_id in metadata assignment
src/tools/atlas/read/getPerformanceAdvisor.ts	Implemented resolveTelemetryMetadata override to include operations array in telemetry events
src/telemetry/types.ts	Extended TelemetryEvent properties with index signature to support arbitrary metadata fields
tests/unit/toolBase.test.ts	Added comprehensive tests for resolveTelemetryMetadata functionality with mock telemetry emission verification
tests/integration/tools/atlas/performanceAdvisor.test.ts	Added telemetry emission tests for operations metadata and reorganized test structure with proper mock setup
tests/integration/elicitation.test.ts	Removed redundant telemetry disable configuration (now handled globally)
tests/accuracy/sdk/accuracyTestingClient.ts	Disabled telemetry in accuracy tests using DO_NOT_TRACK environment variable

[blva]

nice thanks!

[coveralls]

Pull Request Test Coverage Report for Build 18910629949

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 14 (14.29%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 80.429%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/tools/atlasLocal/atlasLocalTool.ts	0	1	0.0%
src/tools/mongodb/mongodbTool.ts	0	1	0.0%
src/tools/atlas/atlasTool.ts	0	2	0.0%
src/tools/atlas/read/getPerformanceAdvisor.ts	1	9	11.11%

Totals
Change from base Build 18907722642:	0.2%
Covered Lines:	6365
Relevant Lines:	7782

---

💛 - Coveralls

[blva]

note: let's make sure to trigger the perf advisor tests here via GH actions

[blva]

[q] why not capture this new field in TelemetryToolMetadata? keeping track of the data we populate there is handy - makes it easy to get a list of properties in the long term

[nirinchev]

That's fair - I think it's a bit annoying if it becomes unwieldy as we add more and more stuff. But you're right that by being overly permissive, we lose oversight into what's being sent to telemetry. I'll try to find a better solution.

[kylelai1]

LGTM!! No specific qualms on the perf advisor tool or testing from me.