Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented Oct 22, 2025

Proposed changes

  • move the perf advisor tasks to post merge and also add the option to trigger them in a specific branch so that we can still use them when doing changes

Checklist

@blva blva force-pushed the long-running-tasks branch from 33dd3cb to 48275c3 Compare October 22, 2025 10:50
@blva blva marked this pull request as ready for review October 22, 2025 10:54
@blva blva requested a review from a team as a code owner October 22, 2025 10:54
Copilot AI review requested due to automatic review settings October 22, 2025 10:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves performance advisor tests to a separate long-running test suite that runs post-merge instead of in the regular test pipeline. Key changes:

  • Separates long-running tests from standard integration tests
  • Increases test timeout for long-running tests to 2 hours
  • Adds new npm script to run long-running tests separately

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
vitest.config.ts Adds new test project for long-running tests with 2-hour timeout and excludes these tests from standard integration suite
tests/integration/helpers.ts Increases default long-running test wait timeout from 15 to 20 minutes
package.json Adds new npm script test:long-running-tests to run the long-running test suite

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@coveralls
Copy link
Collaborator

coveralls commented Oct 22, 2025

Pull Request Test Coverage Report for Build 18714130420

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 181 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.8%) to 80.129%

Files with Coverage Reduction New Missed Lines %
src/common/atlas/cluster.ts 10 50.44%
src/common/atlas/apiClient.ts 21 71.18%
src/tools/atlas/read/getPerformanceAdvisor.ts 61 32.46%
src/common/atlas/performanceAdvisorUtils.ts 89 4.03%
Totals Coverage Status
Change from base Build 18709444254: -1.8%
Covered Lines: 6018
Relevant Lines: 7378

💛 - Coveralls

@blva blva changed the title chore: move perf advisor to long running tests chore: move perf advisor to long running tests - MCP-269 Oct 22, 2025
@blva blva marked this pull request as draft October 22, 2025 11:06
@blva blva marked this pull request as ready for review October 22, 2025 11:14
@blva blva merged commit 7e28a7e into main Oct 22, 2025
20 of 21 checks passed
@blva blva deleted the long-running-tasks branch October 22, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants