feat(atlas-local): Add Atlas Local Create Deployment tool #546
Conversation
|
Test fails due to Windows gh runner. Will be addressed in [MCP-187] |
| // Create the deployment | ||
| await client.createDeployment(deploymentOptions); | ||
|
|
||
| if (deploymentName) { |
There was a problem hiding this comment.
Doesn't await client.createDeployment(deploymentOptions); return the name of the deployment?
There was a problem hiding this comment.
Changed to return deployment and extracted the name
| describe("atlas-local-create-deployment", () => { | ||
| let deploymentNamesToCleanup: string[] = []; | ||
|
|
||
| afterEach(async () => { |
There was a problem hiding this comment.
We don't need to run this on isMacOSInGitHubActions, can we skip it here too?
There was a problem hiding this comment.
I don't see a way to do the skipIf(isMacOSInGitHubActions) or similar for an afterEach. This leaves adding something like this in the afterEach function:
if (isMacOSInGitHubActions) {
return;
}
But since the deploymentToCleanup array will always be empty it will be the same execution time
There was a problem hiding this comment.
Makes sense to not skip it then!
Proposed changes
Ticket: [MCP-156] [mongodb-mcp-server] Implement createLocalAtlasCluster tool
Checklist