- 
                Notifications
    You must be signed in to change notification settings 
- Fork 152
Add MongoDB Assistant Tools #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            nlarew
  wants to merge
  15
  commits into
  mongodb-js:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
nlarew:assistant-tool
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 5 commits
      Commits
    
    
            Show all changes
          
          
            15 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2338504
              
                (EAI-1266) Knowledge Search on MCP
              
              
                nlarew 881c4ee
              
                Add tests for assistant tools
              
              
                nlarew 3bdd3df
              
                Include server version in assistant user-agent header
              
              
                nlarew 59b3c63
              
                get server version from packageInfo
              
              
                nlarew 34d50d8
              
                Merge branch 'main' into assistant-tool
              
              
                nlarew bb5e585
              
                Review
              
              
                nlarew d3b4d6b
              
                Merge branch 'main' of github.com:mongodb-js/mongodb-mcp-server into …
              
              
                nlarew 2736bca
              
                Fix tests + move assistant request up to abstract base class
              
              
                nlarew f8365ac
              
                Don't use zod to parse Assistant API responses
              
              
                nlarew 3cb9883
              
                Merge branch 'main' of github.com:mongodb-js/mongodb-mcp-server into …
              
              
                nlarew 4671347
              
                Give example KB sources in README
              
              
                nlarew 4d887c9
              
                Use custom fetch + treat results as untrusted
              
              
                nlarew caa7792
              
                Update tests for custom fetch + untrusted content formatting
              
              
                nlarew 1415205
              
                Integration -> Unit
              
              
                nlarew f4bec2c
              
                Tweak tool descriptions
              
              
                nlarew File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { TelemetryToolMetadata, ToolArgs, ToolBase, ToolCategory } from "../tool.js"; | ||
| import { CallToolResult } from "@modelcontextprotocol/sdk/types.js"; | ||
| import { Server } from "../../server.js"; | ||
| import { Session } from "../../common/session.js"; | ||
| import { UserConfig } from "../../common/config.js"; | ||
| import { Telemetry } from "../../telemetry/telemetry.js"; | ||
| import { packageInfo } from "../../common/packageInfo.js"; | ||
|  | ||
| export abstract class AssistantToolBase extends ToolBase { | ||
| protected server?: Server; | ||
| public category: ToolCategory = "assistant"; | ||
| protected baseUrl: URL; | ||
| protected requiredHeaders: Record<string, string>; | ||
|  | ||
| constructor( | ||
| protected readonly session: Session, | ||
| protected readonly config: UserConfig, | ||
| protected readonly telemetry: Telemetry | ||
| ) { | ||
| super(session, config, telemetry); | ||
| this.baseUrl = new URL(config.assistantBaseUrl); | ||
| const serverVersion = packageInfo.version; | ||
| this.requiredHeaders = { | ||
| "x-request-origin": "mongodb-mcp-server", | ||
| "user-agent": serverVersion ? `mongodb-mcp-server/v${serverVersion}` : "mongodb-mcp-server", | ||
| }; | ||
| } | ||
|  | ||
| public register(server: Server): boolean { | ||
| this.server = server; | ||
| return super.register(server); | ||
| } | ||
|  | ||
| protected resolveTelemetryMetadata( | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| args: ToolArgs<typeof this.argsShape> | ||
| ): TelemetryToolMetadata { | ||
| return {}; | ||
|         
                  nlarew marked this conversation as resolved.
              Show resolved
            Hide resolved | ||
| } | ||
|  | ||
| protected handleError( | ||
| error: unknown, | ||
| args: ToolArgs<typeof this.argsShape> | ||
| ): Promise<CallToolResult> | CallToolResult { | ||
| return super.handleError(error, args); | ||
| } | ||
|         
                  nlarew marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import { z } from "zod"; | ||
| import { CallToolResult } from "@modelcontextprotocol/sdk/types.js"; | ||
| import { OperationType } from "../tool.js"; | ||
| import { AssistantToolBase } from "./assistantTool.js"; | ||
|  | ||
| export const dataSourceMetadataSchema = z.object({ | ||
| id: z.string().describe("The name of the data source"), | ||
| type: z.string().optional().describe("The type of the data source"), | ||
| versions: z | ||
| .array( | ||
| z.object({ | ||
| label: z.string().describe("The version label of the data source"), | ||
| isCurrent: z.boolean().describe("Whether this version is current active version"), | ||
| }) | ||
| ) | ||
| .describe("A list of available versions for this data source"), | ||
| }); | ||
|  | ||
| export const listDataSourcesResponseSchema = z.object({ | ||
| dataSources: z.array(dataSourceMetadataSchema).describe("A list of data sources"), | ||
| }); | ||
|  | ||
| export class ListKnowledgeSourcesTool extends AssistantToolBase { | ||
| public name = "list_knowledge_sources"; | ||
| protected description = "List available data sources in the MongoDB Assistant knowledge base"; | ||
| protected argsShape = {}; | ||
| public operationType: OperationType = "read"; | ||
|  | ||
| protected async execute(): Promise<CallToolResult> { | ||
| const searchEndpoint = new URL("content/sources", this.baseUrl); | ||
| const response = await fetch(searchEndpoint, { | ||
| method: "GET", | ||
| headers: this.requiredHeaders, | ||
| }); | ||
| if (!response.ok) { | ||
| throw new Error(`Failed to list knowledge sources: ${response.statusText}`); | ||
|         
                  nlarew marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
| } | ||
| const { dataSources } = listDataSourcesResponseSchema.parse(await response.json()); | ||
|  | ||
| return { | ||
| content: dataSources.map(({ id, type, versions }) => ({ | ||
| type: "text", | ||
| text: id, | ||
| _meta: { | ||
| type, | ||
| versions, | ||
| }, | ||
| })), | ||
| }; | ||
| } | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { z } from "zod"; | ||
| import { CallToolResult } from "@modelcontextprotocol/sdk/types.js"; | ||
| import { ToolArgs, OperationType } from "../tool.js"; | ||
| import { AssistantToolBase } from "./assistantTool.js"; | ||
|  | ||
| export const SearchKnowledgeToolArgs = { | ||
| query: z.string().describe("A natural language query to search for in the knowledge base"), | ||
| limit: z.number().min(1).max(100).optional().default(5).describe("The maximum number of results to return"), | ||
| dataSources: z | ||
| .array( | ||
| z.object({ | ||
| name: z.string().describe("The name of the data source"), | ||
| versionLabel: z.string().optional().describe("The version label of the data source"), | ||
| }) | ||
| ) | ||
| .optional() | ||
| .describe( | ||
| "A list of one or more data sources to search in. You can specify a specific version of a data source by providing the version label. If not provided, the latest version of all data sources will be searched." | ||
| ), | ||
| }; | ||
|  | ||
| export const knowledgeChunkSchema = z | ||
| .object({ | ||
| url: z.string().describe("The URL of the search result"), | ||
| title: z.string().describe("Title of the search result"), | ||
| text: z.string().describe("Chunk text"), | ||
| metadata: z | ||
| .object({ | ||
| tags: z.array(z.string()).describe("The tags of the source"), | ||
| }) | ||
| .passthrough(), | ||
| }) | ||
| .passthrough(); | ||
|  | ||
| export const searchResponseSchema = z.object({ | ||
| results: z.array(knowledgeChunkSchema).describe("A list of search results"), | ||
| }); | ||
|  | ||
| export class SearchKnowledgeTool extends AssistantToolBase { | ||
| public name = "search_knowledge"; | ||
|         
                  nlarew marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
| protected description = "Search for information in the MongoDB Assistant knowledge base"; | ||
| protected argsShape = { | ||
| ...SearchKnowledgeToolArgs, | ||
| }; | ||
| public operationType: OperationType = "read"; | ||
|  | ||
| protected async execute(args: ToolArgs<typeof this.argsShape>): Promise<CallToolResult> { | ||
| const searchEndpoint = new URL("content/search", this.baseUrl); | ||
| const response = await fetch(searchEndpoint, { | ||
| method: "POST", | ||
| headers: new Headers({ ...this.requiredHeaders, "Content-Type": "application/json" }), | ||
| body: JSON.stringify(args), | ||
| }); | ||
| if (!response.ok) { | ||
| throw new Error(`Failed to search knowledge base: ${response.statusText}`); | ||
| } | ||
| const { results } = searchResponseSchema.parse(await response.json()); | ||
| return { | ||
| content: results.map(({ text, metadata }) => ({ | ||
| type: "text", | ||
| text, | ||
| _meta: { | ||
| ...metadata, | ||
| }, | ||
| })), | ||
| }; | ||
| } | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { ListKnowledgeSourcesTool } from "./list_knowledge_sources.js"; | ||
| import { SearchKnowledgeTool } from "./search_knowledge.js"; | ||
|  | ||
| export const AssistantTools = [ListKnowledgeSourcesTool, SearchKnowledgeTool]; | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import { setupIntegrationTest, IntegrationTest, defaultTestConfig } from "../../helpers.js"; | ||
| import { describe, SuiteCollector } from "vitest"; | ||
| import { vi, beforeAll, afterAll } from "vitest"; | ||
|  | ||
| export type IntegrationTestFunction = (integration: IntegrationTest) => void; | ||
|  | ||
| export function describeWithAssistant(name: string, fn: IntegrationTestFunction): SuiteCollector<object> { | ||
| const testDefinition = (): void => { | ||
| const integration = setupIntegrationTest(() => ({ | ||
| ...defaultTestConfig, | ||
| assistantBaseUrl: "https://knowledge.test.mongodb.com/api/", // Use test URL | ||
| })); | ||
|  | ||
| describe(name, () => { | ||
| fn(integration); | ||
| }); | ||
| }; | ||
|  | ||
| // eslint-disable-next-line vitest/valid-describe-callback | ||
| return describe("assistant", testDefinition); | ||
| } | ||
|  | ||
| /** | ||
| * Mocks fetch for assistant API calls | ||
| */ | ||
| interface MockedAssistantAPI { | ||
| mockListSources: (sources: unknown[]) => void; | ||
| mockSearchResults: (results: unknown[]) => void; | ||
| mockAPIError: (status: number, statusText: string) => void; | ||
| mockNetworkError: (error: Error) => void; | ||
| mockFetch: ReturnType<typeof vi.fn>; | ||
| } | ||
|  | ||
| export function makeMockAssistantAPI(): MockedAssistantAPI { | ||
| const mockFetch = vi.fn(); | ||
|  | ||
| beforeAll(() => { | ||
| global.fetch = mockFetch; | ||
| }); | ||
|  | ||
| afterAll(() => { | ||
| vi.restoreAllMocks(); | ||
| }); | ||
|  | ||
| const mockListSources: MockedAssistantAPI["mockListSources"] = (sources) => { | ||
| mockFetch.mockResolvedValueOnce({ | ||
| ok: true, | ||
| json: () => Promise.resolve({ dataSources: sources }), | ||
| }); | ||
| }; | ||
|  | ||
| const mockSearchResults: MockedAssistantAPI["mockSearchResults"] = (results) => { | ||
| mockFetch.mockResolvedValueOnce({ | ||
| ok: true, | ||
| json: () => Promise.resolve({ results }), | ||
| }); | ||
| }; | ||
|  | ||
| const mockAPIError: MockedAssistantAPI["mockAPIError"] = (status, statusText) => { | ||
| mockFetch.mockResolvedValueOnce({ | ||
| ok: false, | ||
| status, | ||
| statusText, | ||
| }); | ||
| }; | ||
|  | ||
| const mockNetworkError: MockedAssistantAPI["mockNetworkError"] = (error) => { | ||
| mockFetch.mockRejectedValueOnce(error); | ||
| }; | ||
|  | ||
| return { | ||
| mockListSources, | ||
| mockSearchResults, | ||
| mockAPIError, | ||
| mockNetworkError, | ||
| mockFetch, | ||
| }; | ||
| } | ||
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.