Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

COMPASS-4409: Adds icon click handler to modal status message #25

Merged
merged 2 commits into from
Nov 6, 2020
Merged

COMPASS-4409: Adds icon click handler to modal status message #25

merged 2 commits into from
Nov 6, 2020

Conversation

rose-m
Copy link
Contributor

@rose-m rose-m commented Nov 5, 2020

Description

Added an optional icon click handler to the modal-status-message component to allow interaction with the message.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@rose-m rose-m self-assigned this Nov 5, 2020
mcasimir
mcasimir approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

gribnoysup
gribnoysup reviewed Nov 5, 2020
View reviewed changes
@rose-m rose-m merged commit 4600491 into master Nov 6, 2020
@rose-m rose-m deleted the COMPASS-4409-allow-modal-message-interaction branch November 6, 2020 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Anemy Anemy Anemy left review comments

@gribnoysup gribnoysup gribnoysup left review comments

@mcasimir mcasimir mcasimir approved these changes

Assignees

@rose-m rose-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rose-m @mcasimir @Anemy @gribnoysup