feat(build-info): identify server name COMPASS-9930 #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Oct 24, 2025
addaleax
requested changes
Oct 24, 2025
kraenhansen
force-pushed
the
kh/build-info-identify-server-name
branch
from
d68cd4a to
73f6e71
Compare
addaleax
approved these changes
Oct 27, 2025
| } | ||
|
|
||
| try { | ||
| await adminCommand({ getParameter: 'foo' }); |
There was a problem hiding this comment.
We're sensitive about startup times in some products (e.g. mongosh) so I'd suggest running the commands in parallel and awaiting with Promise.all()
… only adminCommand
kraenhansen
force-pushed
the
kh/build-info-identify-server-name
branch
from
73f6e71 to
6adc59d
Compare
addaleax
approved these changes
Oct 27, 2025
gribnoysup
reviewed
Oct 27, 2025
| connectionString, | ||
| adminCommand, | ||
| }: IdentifyServerNameOptions): Promise<string> { | ||
| try { |
There was a problem hiding this comment.
Can we short-circuit on mongodb.net hosts here to make sure we're not wasting time running these commands in web?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to run commands to determine server name.
Open Questions
Checklist