This repository was archived by the owner on May 17, 2021. It is now read-only.
fix: Use latest connection-model and keep reference to tunnel to be able to close it when disconnecting native client COMPASS-4474 #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble to close it when disconnecting native client COMPASS-4474
rose-m
approved these changes
Mar 9, 2021
|
@alenakhineika good point, not sure we can write one without mocking a whole bunch of stuff, but will add something! Thanks for nudging me to write more tests, I am getting a bit lazy with it sometimes 😊 |
addaleax
approved these changes
Mar 9, 2021
|
@alenakhineika added a test case in 5bb7cbc |
gribnoysup
deleted the
compass-4474-make-sure-ssh-tunnel-is-closed-on-disconnect
branch
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to mongodb-js/connection-model#352 that makes sure that when
connection-modelreturns a tunnel during connect, we close it before resolving adisconnectcallback