-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): remove accelerators for linux COMPASS-8494 #6485
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test, similar to the one that was added in the backport PR you opened, that checks that the menus we build are working on the platforms we're running these tests at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in 2ef8483
const menu = Menu.buildFromTemplate([ | ||
{ | ||
label: 'Test Super', | ||
accelerator: 'Super+Ctrl+T', | ||
}, | ||
{ | ||
label: 'Test Meta', | ||
accelerator: 'Meta+Ctrl+T', | ||
}, | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use our template here so that we're checking that our template works on all platforms? 🙂 (this will probably fail now because this includes accelerator and will run on linux)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added more checks and also skipped the tests for linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is some kind of misunderstanding here: the fix you're making is programmatically changing the template generated by our code in a way that should make it usable on linux, I want us to have a test that checks that the generated template actually works on linux (not tangentially checking it through something arbitrary like whether or not acceletator key is present), more specifically: I want this test to build our template and then run it through the logic in this test that would trigger the break if we're not doing it correctly and it should run on linux too as we're expecting the introduced change to make it work on linux. Does this make sense?
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes