fix(deps): bump electron to 32.2.1 COMPASS-8399 #6387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also does the compass-specific bits of COMPASS-8253. Fixes: #6122 Fixes: #6334
Anemy
approved these changes
Oct 22, 2024
addaleax
changed the title
gribnoysup
approved these changes
Oct 24, 2024
gribnoysup
reviewed
Oct 24, 2024
Comment on lines
290
to
301
| let _electron: typeof import('electron') | undefined | null; | ||
| // eslint-disable-next-line @typescript-eslint/consistent-type-imports | ||
| function getElectronWebUtils(): typeof import('electron').webUtils | undefined { | ||
| if (_electron === undefined) { | ||
| try { | ||
| _electron = require('electron'); | ||
| } catch { | ||
| _electron = null; | ||
| } | ||
| } | ||
| return _electron?.webUtils; | ||
| } |
There was a problem hiding this comment.
Just to follow the pattern of hiding direct electron usage behind the FileInputBackend interface, what do you think about adding getPathForFile as an extra method to the interface instead of importing electron here directly?
There was a problem hiding this comment.
Oh, yeah, that's definitely a better way of going about this! Did this in 9c27dd7
This reverts commit fb4f812.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also does the compass-specific bits of COMPASS-8253.
Fixes: #6122
Fixes: #6334
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes