Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): run static analysis reporting only once per version COMPASS-7998 #5897

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

addaleax
Copy link
Collaborator

No description provided.

@@ -1,4 +1,3 @@
unset_function_vars: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by: This field does not exist anymore

@@ -331,7 +331,6 @@ functions:
wait: true
# copy ssh key (this key will be used to connect to ssh server)
- command: shell.exec
silent: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by: silent would need to be set on the params:, not the command, if we wanted it to have an effect – but this should be fine either way, so let's just drop the invalid extra key

@addaleax addaleax added the no release notes Fix or feature not for release notes label Jun 11, 2024
@github-actions github-actions bot added the fix label Jun 11, 2024
@addaleax addaleax merged commit 63169c3 into main Jun 12, 2024
16 checks passed
@addaleax addaleax deleted the 7998-dev branch June 12, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants