wip: export schema dialog #5690
Conversation
packages/compass-schema/src/components/export-schema/export-schema-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-schema/src/components/export-schema/export-schema-modal.tsx
Outdated
Show resolved
Hide resolved
| import type { Schema } from 'mongodb-schema'; | ||
| import React, { useMemo, useState, useCallback } from 'react'; | ||
|
|
||
| import { JSONEditor } from '@mongodb-js/compass-editor'; |
There was a problem hiding this comment.
This needs to be declared as a dependency in package.json :)
| settings={ | ||
| <> | ||
| <Checkbox | ||
| label="Include _id" |
There was a problem hiding this comment.
Would it make sense to highlight _id as code here?
| label="Include _id" | |
| label={<>Include <InlineCode>_id</InlineCode></>} |
There was a problem hiding this comment.
(this applies for the other format as well)
| MongoDB Validation Schema ($jsonSchema) | ||
| </Option> | ||
| <Option value="jsonSchema">JSON Schema (EJSON)</Option> | ||
| <Option value="internalSchema">Compass Internal Schema</Option> |
There was a problem hiding this comment.
We're providing this for compatibility with the legacy feature that used this format until now? "Internal" sounds a bit like users aren't really supposed to rely on it :)
There was a problem hiding this comment.
good point yeah, not sure what we could call that instead, or if we want to just drop it, maybe we can add an "x-samples: [...]" to the json schema and just get rid of this one
| <Option value="mongodbJsonSchema"> | ||
| MongoDB Validation Schema ($jsonSchema) | ||
| </Option> | ||
| <Option value="jsonSchema">JSON Schema (EJSON)</Option> |
There was a problem hiding this comment.
I admittedly didn't understand what this meant until I looked at the source code, i.e. that this is the JSON schema for the EJSON representation of the BSON objects, kind of makes sense but maybe we can have a line below the Select to explain what the currently selected format actually means?
There was a problem hiding this comment.
That's probably a great idea yeah, awesome that you reviewed these changes! We probably want to rewrite this entire thing, but maybe i should try to rebase this one day, still better to start from something more or less "real"
…hema-modal.tsx Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
…hema-modal.tsx Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
No description provided.