Conversation
Anemy
changed the title
gribnoysup
reviewed
Aug 15, 2023
gribnoysup
approved these changes
Aug 15, 2023
Collaborator
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
Looks good, left one comment, but feel free to ignore it if it doesn't make sense to you
Comment on lines
+115
to
+121
| // Check that the request was made with the correct parameters. | ||
| const requests = getRequests(); | ||
| expect(requests.length).to.equal(1); | ||
| expect(requests[0].content.userInput).to.equal(testUserInput); | ||
| expect(requests[0].content.collectionName).to.equal('numbers'); | ||
| expect(requests[0].content.databaseName).to.equal('test'); | ||
| expect(requests[0].content.schema).to.exist; |
Collaborator
There was a problem hiding this comment.
Feel free to keep it, but this is something we already cover with functional tests and I don't think redundancy is needed here. From our e2e tests I would mostly expect testing that the UI is correctly handling user interactions
I know that we do a similar thing for analytics, but this is not something we usually cover with unit / functional, so there it makes more sense to check specifically what got pushed to the backend
Member
Author
There was a problem hiding this comment.
Makes sense, I'll remove those extra checks in another pr to avoid another test ci run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPASS-6978
Starts a mock server, opens the ai input, enters a prompt, runs it, ensures that the query populates and is runnable. These tests use environment variables to skip the Atlas login. We might want to actually sign into Atlas as part of the end to end test, at least in evergreen. I can make a follow up ticket or do it here depending on how folks feel.