Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

build: COMPASS-3933: Fixing up deps #38

Merged
merged 9 commits into from
Jan 28, 2020
Merged

build: COMPASS-3933: Fixing up deps #38

merged 9 commits into from
Jan 28, 2020

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented Jan 27, 2020

  • COMPASS-3933: Electron 6 updates
  • Latest travis.yml template

fix: Update javascript-stringify

  • Was being used as a transitive dep from query-parser which updated to javascript-stringify@2 causing test break

ci: use xvfb-maybe

Need to use https://npm.im/xvfb-maybe to configure the travis run for electron (needs a virtual buffer xvfb-maybe configures as needed)

> @mongodb-js/compass-schema-validation@3.1.0 test:karma /home/travis/build/mongodb-js/compass-schema-validation
> cross-env NODE_ENV=test karma start
START:
ℹ 「wdm」: Compiled successfully.
27 01 2020 22:57:26.260:ERROR [launcher]: Cannot start Electron
	
(electron:8394): Gtk-WARNING **: 22:57:26.250: cannot open display: 
27 01 2020 22:57:26.261:ERROR [launcher]: Electron stdout: 
27 01 2020 22:57:26.261:ERROR [launcher]: Electron stderr: 
(electron:8394): Gtk-WARNING **: 22:57:26.250: cannot open display: 
27 01 2020 22:57:26.313:ERROR [launcher]: Cannot start Electron
	
(electron:8407): Gtk-WARNING **: 22:57:26.311: cannot open display: 
27 01 2020 22:57:26.313:ERROR [launcher]: Electron stdout: 
27 01 2020 22:57:26.314:ERROR [launcher]: Electron stderr: 
(electron:8407): Gtk-WARNING **: 22:57:26.311: cannot open display: 
27 01 2020 22:57:26.364:ERROR [launcher]: Cannot start Electron
	
(electron:8417): Gtk-WARNING **: 22:57:26.362: cannot open display: 
27 01 2020 22:57:26.365:ERROR [launcher]: Electron stdout: 
27 01 2020 22:57:26.365:ERROR [launcher]: Electron stderr: 
(electron:8417): Gtk-WARNING **: 22:57:26.362: cannot open display: 
27 01 2020 22:57:26.365:ERROR [launcher]: Electron failed 2 times (cannot start). Giving up.
Finished in 0 secs / 0 secs @ 22:57:26 GMT+0000 (Coordinated Universal Time)

- Was being used asa transitive dep from query-parser which updated to `javascript-stringify@2` causing test break
- Also update to `mongodb-query-parser@2.0.0` mongodb-js/query-parser#22
- query-parser 2.0
- latest travis.yml template
- remove electron-packager
- cleanup readme
@imlucas imlucas merged commit 512d668 into master Jan 28, 2020
@imlucas imlucas deleted the COMPASS-3933 branch January 28, 2020 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant