fix: Add mongodb-query-parser and use its stringify COMPASS-4481

package.json

@@ -163,6 +163,7 @@
     "marky": "^1.2.1",
     "mime-types": "^2.1.24",
     "mongodb-extjson": "^4.0.0-rc1",
+    "mongodb-query-parser": "^2.1.2",
     "mongodb-schema": "^8.2.5",
     "object-sizeof": "^1.5.1",
     "parse-json": "^5.0.0",

src/utils/get-shell-js.js

@@ -1,11 +1,11 @@
-import { stringify as toJavascriptString } from 'javascript-stringify';
+import {stringify} from 'mongodb-query-parser';
 import toNS from 'mongodb-ns';
 
 export default function(ns, spec) {
   let ret = `db.${toNS(ns).collection}.find(\n`;
-  ret += '  ' + toJavascriptString(spec.filter, null, '');
+  ret += '  ' + stringify(spec.filter, '');
   if (spec.project) {
-    ret += ',\n  ' + toJavascriptString(spec.project, null, '');
+    ret += ',\n  ' + stringify(spec.project, '');
   }
   ret += '\n)';
   if (spec.limit) {

src/utils/get-shell-js.spec.js

@@ -1,10 +1,18 @@
+import {ObjectId} from 'bson';
 import getShellJS from './get-shell-js';
 
 describe('get-shell-js', () => {
   it('should support simple query', () => {
     const ret = getShellJS('lucas.pets', { filter: { name: 'Arlo' } });
     const expected = `db.pets.find(
-  {name:'Arlo'}
+  {name: 'Arlo'}
+)`;
+    expect(ret).to.equal(expected);
+  });
+  it('should support simple ObjectId', () => {
+    const ret = getShellJS('lucas.pets', { filter: { _id: new ObjectId('deadbeefdeadbeefdeadbeef') } });
+    const expected = `db.pets.find(
+  {_id: ObjectId('deadbeefdeadbeefdeadbeef')}
 )`;
     expect(ret).to.equal(expected);
   });
@@ -14,8 +22,8 @@ describe('get-shell-js', () => {
       project: { name: 1 }
     });
     const expected = `db.pets.find(
-  {name:'Arlo'},
-  {name:1}
+  {name: 'Arlo'},
+  {name: 1}
 )`;
     expect(ret).to.equal(expected);
   });
@@ -26,8 +34,8 @@ describe('get-shell-js', () => {
       limit: 100
     });
     const expected = `db.pets.find(
-  {name:'Arlo'},
-  {name:1}
+  {name: 'Arlo'},
+  {name: 1}
 ).limit(100)`;
 
     expect(ret).to.equal(expected);
@@ -40,8 +48,8 @@ describe('get-shell-js', () => {
       skip: 1
     });
     const expected = `db.pets.find(
-  {name:'Arlo'},
-  {name:1}
+  {name: 'Arlo'},
+  {name: 1}
 ).limit(100).skip(1)`;
 
     expect(ret).to.equal(expected);